Removing UnitConverters from v4 (attempt 2) #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that entire converters file can be removed
Keeping it only for VectorField.eval()
Temporarily, as #2461 will move this unit conversion to the vector-interpolators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally based and merged #2459, removing UnitConverters from v4, into the
fieldset_from_nemobranch instead ofv4_dev. But since that branch will not be merged (superseded by #2460) the entire git history was botchedIn this PR, I cherry-picked the 10 commits in #2459 and now merge them directly into v4-dev